Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for PD 3.1 column naming #98

Merged
merged 3 commits into from
Oct 18, 2024
Merged

added support for PD 3.1 column naming #98

merged 3 commits into from
Oct 18, 2024

Conversation

mstaniak
Copy link
Contributor

Motivation and Context

#90

Changes

Please provide a detailed bullet point list of your changes.

  • added a run_column variable which takes one of the values: "FileID", "SpectrumFile", depending on what is found in the input columns
  • modified column validation function to account for this change

Testing

None

Checklist Before Requesting a Review

  • [x ] I have read the MSstats contributing guidelines
  • [ x] My changes generate no new warnings
  • [ x] Any dependent changes have been merged and published in downstream modules

@mstaniak
Copy link
Contributor Author

https://docs.thermofisher.com/r/Proteome-Discoverer-3.1-User-Guide/en-US1325257611v1 current column names

@mstaniak mstaniak merged commit 4e5836f into devel Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonywu1999 tonywu1999 tonywu1999 approved these changes

@devonjkohler devonjkohler Awaiting requested review from devonjkohler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstaniak @tonywu1999